Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update node version to 20 #171

Merged
merged 3 commits into from
Aug 31, 2023
Merged

feat: update node version to 20 #171

merged 3 commits into from
Aug 31, 2023

Conversation

enell
Copy link
Contributor

@enell enell commented Aug 15, 2023

Type of Change

  • New feature
  • Bug fix
  • Documentation
  • Refactor
  • Chore

Resolves

Describe Changes

Node20 is being rolled out on github runnes

@MikeMcC399
Copy link
Contributor

@enell

I would consider this a breaking change leading to a new major version bump, not simply a chore:.

Also the documentation would need updating, for instance: https://github.com/cycjimmy/semantic-release-action#semantic_version

@enell
Copy link
Contributor Author

enell commented Aug 15, 2023

Yes you are correct. But is is a fix or feat?

@MikeMcC399
Copy link
Contributor

Hopefully @cycjimmy will get involved and assist with the PR!

@enell enell changed the title chore: update node version to 20 chore!: update node version to 20 Aug 16, 2023
@enell enell marked this pull request as ready for review August 16, 2023 07:29
@Alegrowin
Copy link

@enell I went a little ahead and upgraded to semantic release 21 and node 20 as a default everywhere.

https://github.com/enell/semantic-release-action/pull/1/files

@cycjimmy
Copy link
Owner

I've been a bit busy with my current job and will probably attempt a new upgrade version next week.
The new version will be a BREAKING CHANGE. If you are trying to upgrade, you can submit using the feat keyword and add BREAKING CHANGE to the commit message footer.

BREAKING CHANGE: set the default node version to 20
@MikeMcC399
Copy link
Contributor

@enell

You need to have the following text included literally in your commit:

BREAKING CHANGE:

and this would be

feat:

not simply

chore!:

I'm just echoing what @cycjimmy already wrote in #171 (comment), in case it was not clear to you.

@enell enell changed the title chore!: update node version to 20 feat: update node version to 20 Aug 24, 2023
@enell
Copy link
Contributor Author

enell commented Aug 24, 2023

@MikeMcC399 Just updated

@cycjimmy cycjimmy merged commit 31a37a4 into cycjimmy:main Aug 31, 2023
4 checks passed
@github-actions
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cycjimmy
Copy link
Owner

This PR has been updated to the main branch. The new version is v4.
Thanks for your contributions.

@enell enell deleted the node20 branch September 1, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatibility with semantic-release >v20
4 participants