Fix mousemove bug, ghost offset bug, requiring children if no handle …

[jvanbruegge]

…option set, remove need for emitBetween, use border-box, add code to implement ghostClass options

Continuation of #15

[ntilwalli]

@jvanbruegge I just tried the manyFixes branch and it works for me. I have the selectionDelay option set to non-zero for the simple example, which means you need to keep mousedown for a certain period of time before the selection becomes active. I tested with the simple and horizontal examples. Which example did you test?

[ntilwalli]

Also I needed to switch to @types/handlebars to v4.0.33 due to this issue: DefinitelyTyped/DefinitelyTyped#18025

[jvanbruegge]

The parentSelector example has a weird offset and the update example throws an error

Also I needed to switch to @types/handlebars

We are not using handlebars?

[ntilwalli]

The reason the updateEvent example is crashing is because the selectionDelay default value is missing. Seems that code change was skipped during the merge. You can see the additional line in my local branch: https://github.com/ntilwalli/cyclejs-sortable/blob/master/src/helpers.ts#L25

[ntilwalli]

Also the @types/handlebars seems to be required by typedoc. I did a fresh npm install and it pulled in 4.0.35 which caused the build to fail. Overriding that lib to 4.0.33 allowed the build to work... dunno

[jvanbruegge]

No, that line is also in the merge: https://github.com/cyclejs-community/cyclejs-sortable/pull/16/files#diff-78060b682ecec44974ea9e5dde4a8310R36

[ntilwalli]

Typo/bug. The options.selectionDelay should read defaults.selectionDelay

[ntilwalli]

Changing that line will fix the issue in the updateEvent example

[ntilwalli]

The whole line should read .compose(delay(defaults.selectionDelay))

[jvanbruegge]

Weird that typescriot did not complain

[ntilwalli]

TS didn't complain because an 'options' variable exists in the scope. 'defaults' is the normalized version of 'options' which contains the defaults.

[ntilwalli]

Regarding the weird offsets, the parent elements all need to have position: relative added to their css styles. That applies to both the updateEvent and parentSelector examples. Would you like me to make the updates (including the selectionDelay issue) and resubmit a PR?

[jvanbruegge]

Please make a Pr based on this one, then I can squash&merge

[ntilwalli]

#17