Throw if composed stream emits array #18
Merged
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also updated snabbdom-selector and allowed children nodes to be falsy... |
jvanbruegge
reviewed
Oct 4, 2017
| @@ -50,6 +50,8 @@ export function addKeys( | |||
| node: VNode, | |||
| key: string = Math.random().toString() | |||
| ): VNode { | |||
| if (!node) return; | |||
There was a problem hiding this comment.
I would throw here too
There was a problem hiding this comment.
It's not meant to be an error check. I added that line to skip falsy children VNodes like null and undefined, which is something @cycle/dom offers.
jvanbruegge
approved these changes
Oct 4, 2017
|
Will merge and publish once home |
|
Published in 2.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures the user does not emit arrays directly, but wraps VNode arrays in a parent VNode before composing with
makeSortable