-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
secured bicycle parking icon rework #228
Conversation
Nice ! Can you make a snapshot of an example of the map with these new icons ? |
I also have a concern with limited access bicycle parkings. We currently render them with an opacity of 0.33 and this does not render very well with these new icons. Not sure how to fix this, maybe increase the size of the white inner ring? This is located at https://www.cyclosm.org/#map=20/48.85306/2.36761/cyclosm. |
Hello, |
I've changed the square into simple contour corners. I hope it has good rendering, but unfortunately I have no way to test it for now. |
Sorry for coming back late on this :/ Opacity looks good now, thanks! One minor issue, in my opinion, is that the "lock" is not strong enough. The only main visual difference once rendered are the small triangles in the corners. What do you think? For the record, the bicycle parking icons are rendered with a size of 8 pixels (could be increased a bit to 10 if required, but render is currently the same). |
I try it myself, and I wasn’t happy with the result. |
Current icon size is 8 pixels (width, height is determined from the marker size). We could enlarge it to 10 pixels, but it does not change much :/ |
The top of the « covered » icons ? I kept the uncovered one light to make clear difference |
Yes, only for the covered ones (actually,the locked ones). Currently, the locked ones have a strong basis and a lighter top. What about locking symmetrically? |
Here I tried to make top of lock stronger for both covered and uncovered secured |
Thanks! |
Hello,
here is a rework of icon files for #226.