Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secured bicycle parking icon rework #228

Merged
merged 4 commits into from
Nov 21, 2019
Merged

secured bicycle parking icon rework #228

merged 4 commits into from
Nov 21, 2019

Conversation

quasart
Copy link
Contributor

@quasart quasart commented Oct 29, 2019

Hello,
here is a rework of icon files for #226.

@Florimondable
Copy link
Member

Nice !
The roof of the secured parking icons (squared ones) doesn’t have the same width as the other ones.
Can you correct that please ?

Can you make a snapshot of an example of the map with these new icons ?

@Phyks
Copy link
Member

Phyks commented Oct 30, 2019

I also have a concern with limited access bicycle parkings. We currently render them with an opacity of 0.33 and this does not render very well with these new icons. Not sure how to fix this, maybe increase the size of the white inner ring?

Screenshot_2019-10-30 CyclOSM — Kosmtik

This is located at https://www.cyclosm.org/#map=20/48.85306/2.36761/cyclosm.

@quasart
Copy link
Contributor Author

quasart commented Oct 30, 2019

Hello,
Opacity looks applied on every subpart of the svg, and not on the icon itself. I’ll try to provide « flat » svg without overlapping shapes. It should look better.

@quasart
Copy link
Contributor Author

quasart commented Oct 30, 2019

I've changed the square into simple contour corners. I hope it has good rendering, but unfortunately I have no way to test it for now.

@Phyks
Copy link
Member

Phyks commented Nov 6, 2019

Sorry for coming back late on this :/ Opacity looks good now, thanks!

Screenshot_2019-11-06 CyclOSM — Kosmtik

One minor issue, in my opinion, is that the "lock" is not strong enough.

2Screenshot_2019-11-06 CyclOSM — Kosmtik

The only main visual difference once rendered are the small triangles in the corners.

What do you think?

For the record, the bicycle parking icons are rendered with a size of 8 pixels (could be increased a bit to 10 if required, but render is currently the same).

@Florimondable
Copy link
Member

For the record, the bicycle parking icons are rendered with a size of 8 pixels (could be increased a bit to 10 if required, but render is currently the same).

I try it myself, and I wasn’t happy with the result.
So I try to put the dot into a full square box, and I figure out that the icon is size fixed as you mentioned.
But I don’t like the idea to add an other rule for just the size of an icon.
May be we can try to reduce the size of the dot, or render the dot in white and the "house" in blue ?

@Phyks
Copy link
Member

Phyks commented Nov 7, 2019

I figure out that the icon is size fixed as you mentioned.

Current icon size is 8 pixels (width, height is determined from the marker size). We could enlarge it to 10 pixels, but it does not change much :/

@quasart
Copy link
Contributor Author

quasart commented Nov 7, 2019

Hello,
if width is fixed but not height, we may use height to make secured icon stronger. Here is a new try with a thicker base added :
test

@Phyks
Copy link
Member

Phyks commented Nov 8, 2019

if width is fixed but not height

It should be the case, and indeed it should be fine to have non-square icons.

Here is a new try with a thicker base added :

Looks better! Maybe we should make the top stronger as well?

Screenshot_2019-11-08 CyclOSM — Kosmtik

@quasart
Copy link
Contributor Author

quasart commented Nov 8, 2019

The top of the « covered » icons ? I kept the uncovered one light to make clear difference

@Phyks
Copy link
Member

Phyks commented Nov 10, 2019

The top of the « covered » icons ?

Yes, only for the covered ones (actually,the locked ones). Currently, the locked ones have a strong basis and a lighter top. What about locking symmetrically?

@quasart
Copy link
Contributor Author

quasart commented Nov 18, 2019

Here I tried to make top of lock stronger for both covered and uncovered secured

@Phyks
Copy link
Member

Phyks commented Nov 21, 2019

Thanks!

@Phyks Phyks merged commit e75d1bd into cyclosm:master Nov 21, 2019
@Florimondable
Copy link
Member

Florimondable commented Nov 23, 2019

Result for the record, it's good :
Capture du 2019-11-23 21-52-29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants