Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polishing 3 : railway stations, roads at z9-10, access private #273

Merged
merged 15 commits into from
Jan 26, 2020

Conversation

Florimondable
Copy link
Member

Code cleaning.
fix #272 and #262
fix almost #255 but I'm not able to render tertiary (WTF?)

Capture du 2020-01-03 23-11-53

@Florimondable
Copy link
Member Author

Add allotments, wetland and some naturals (glacier is still missing at least) (for #229)
Should fix #263 (tourism point of view in brown) and #265 (allotments)

@Florimondable Florimondable changed the title Polishing 3 : railway stations, roads at z9-10 Polishing 3 : railway stations, roads at z9-10, access private Jan 18, 2020
@Florimondable
Copy link
Member Author

fix #259 private access roads in grey

access_private_montrouge

roads.mss Show resolved Hide resolved
roads.mss Outdated Show resolved Hide resolved
roads.mss Show resolved Hide resolved
project.mml Outdated Show resolved Hide resolved
@Phyks
Copy link
Member

Phyks commented Jan 26, 2020

but I'm not able to render tertiary (WTF?)

roads_med layer is using planet_osm_roads table (not planet_osm_line table as used on upper zoom levels). This table only contains a subset of roads, which are useful at low zoom level (for perf), see https://gis.stackexchange.com/questions/37099/in-osm2pgsql-how-is-the-planet-osm-roads-table-populated.

In particular, it only has very few tertiary. The logic is basically described in https://github.com/openstreetmap/osm2pgsql/blob/master/style.lua (we are not exactly using this, but the core ideas of the logic are the same, check for the roads items). The few tertiaries listed in planet_osm_roads table are coming from artifacts from other items being added into this table (administrative boundaries along a tertiary for instance).

I'd expect the tertiary to have too much clutter at Z9/Z10, I would be in favor or removing them from roads_med layer.

@Phyks
Copy link
Member

Phyks commented Jan 26, 2020

Few comments above, once settled I'm ready to merge this PR and publish a new version of the CyclOSM style :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Halt train station are not rendered
2 participants