Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null in 'not' in cycle route node query for zoom 8-10 #299

Merged
merged 3 commits into from
Feb 7, 2020
Merged

Fix null in 'not' in cycle route node query for zoom 8-10 #299

merged 3 commits into from
Feb 7, 2020

Conversation

hiddewie
Copy link
Contributor

@hiddewie hiddewie commented Feb 6, 2020 •
edited
Loading

Fix #297.

There were null values in the query because not all ways have the tags in the query (of course...). And null is not false in SQL, but resolves the whole WHERE to null.

Current live map

Zoom 8

image

Zoom 10

image

After fix

Zoom 8

image

Zoom 10

image

@Phyks
Copy link
Member

Phyks commented Feb 7, 2020

Nice catch! Thanks!

@Phyks Phyks merged commit da8f77c into cyclosm:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't see anymore regional route at z8-10
2 participants
@hiddewie @Phyks