Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update call to Package::GetFillMass #630

Merged
merged 1 commit into from
Sep 30, 2024
Merged

update call to Package::GetFillMass #630

merged 1 commit into from
Sep 30, 2024

Conversation

nuclearkatie
Copy link
Contributor

@nuclearkatie nuclearkatie commented Sep 25, 2024 •
edited
Loading

Must be merged after cyclus#1813. Tests on latest should be re-run and should pass after that's merged

@nuclearkatie nuclearkatie self-assigned this Sep 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 25, 2024 •
edited
Loading

Build Status Report - 1ed34c3 - 2024-09-25 19:32:45 +0000

Build FROM cyclus_20.04_apt/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_20.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_conda/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_20.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_apt/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_22.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_conda/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_22.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️

@nuclearkatie nuclearkatie mentioned this pull request Sep 26, 2024
Merged
@nuclearkatie nuclearkatie requested a review from gonuke September 26, 2024 17:24
@nuclearkatie nuclearkatie marked this pull request as ready for review September 26, 2024 17:25
gonuke
gonuke approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sure look simpler... I'll merge it when cyclus is updated.

@nuclearkatie
Copy link
Contributor Author

@gonuke I just re-ran tests and they pass now on latest

@gonuke gonuke merged commit a4ea59d into cyclus:main Sep 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonuke gonuke gonuke approved these changes

Assignees

@nuclearkatie nuclearkatie

Labels
None yet
Projects
None yet
Milestone
Bulk-to-Discrete packaging
Development

Successfully merging this pull request may close these issues.
2 participants
@nuclearkatie @gonuke