Changed "-" to "_" in Input File Examples in Tutorial #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase to reserve merge conflicts and I'll try to review quickly |
…of the pages of tutorial
dean-krueger
force-pushed
the
doc-updates
branch
from
e85e3ba to
09e9493
Compare
|
Should be fixed now. |
gonuke
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
LGTM! Thanks @dean-krueger ...
Note: while I'm fine to approve these changes, I'm surprised that these don't work with the hyphen and wonder if we should separately understand if that's universally true or some configuration thing...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently in Cyclus input files you cannot have "-" in the names of things. However, in the tutorials on the website we were telling people to make variables like "u-ore" and "fresh-uox", so I went in and changed all of those to "u_ore" and "fresh_uox", etc. I also added a note above one of the images which showed an incorrect variable name that you aren't allowed to have "-" in your names so it was more clear/consistent.
This PR Closes #394