Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use action/checkout v4 instead of v2 in tests #16

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

mlocati
Copy link
Contributor

@mlocati mlocati commented Oct 21, 2024

No description provided.

@jon-turney
Copy link
Member

Oh my! That's wrong! Well spotted!

But I think that should be uses: ./ everywhere, so we use the action from the currently checked out repository.

@mlocati
Copy link
Contributor Author

mlocati commented Oct 21, 2024

But I think that should be uses: ./ everywhere

That's what we currently have: see for example:

    - uses: actions/checkout@v2

    - name: Install Cygwin
      uses: ./
      with:
        platform: ${{ matrix.platform }}
        packages: ${{ matrix.packages }}
        add-to-path: false

so we use the action from the currently checked out repository

We need to checkout the repo: the action doesn't do that automatically.

@mlocati
Copy link
Contributor Author

mlocati commented Oct 21, 2024

PS: about the failing tests see the "Installer freezes in windows-2022 GitHub Action" thread of https://cygwin.com/pipermail/cygwin/2024-October/thread.html

@jon-turney
Copy link
Member

Sorry, completely misunderstood this. Somehow my brain decided the v4 tag was the version of this action, not the checkout action. More coffee needed obviously.

So this is just "update the version of the checkout action in tests", and obviously right.

Thanks

@jon-turney jon-turney merged commit 3bb2cf5 into cygwin:master Oct 21, 2024
3 of 12 checks passed
@mlocati mlocati deleted the checkout-v4 branch October 21, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants