Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for changes to the config files #78

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

dpmatthews
Copy link
Contributor

Addresses cylc/cylc-flow#3422.
Intended for discussion at the workshop.

I've attempted to go through all the previous discussion and list everything that was proposed.
Hopefully we can agree which changes are worthwhile and then implement them incrementally.
Many of the changes appeared to have general support in the previous discussions which I've referenced so hopefully we won't need to debate them all in detail.

Reviewers: please just check that nothing obvious is missing or wrong.

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Halfway through it, looks good so far...

@hjoliver hjoliver force-pushed the master branch 3 times, most recently from bb1da53 to 8d03fb0 Compare February 3, 2020 06:06
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, so we can put this up as workshop reading material. I'll make some minor adjustments based on feedback and discussion on the issue, post merge...

@hjoliver hjoliver merged commit b041255 into cylc:master Feb 5, 2020
@dpmatthews dpmatthews deleted the config-review branch February 5, 2020 07:49
@oliver-sanders
Copy link
Member

FYI: The Scheduler already "unifies" the workflow and global configurations for all settings in the [cylc] section, or at least it looks for the configuration in both.

https://github.com/cylc/cylc-flow/blob/166a51859764e54a7a1cbde8b072b0357ca9670e/cylc/flow/scheduler.py#L2087-L2099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants