Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config changes proposal based on CylcCon discussion #90

Merged
merged 2 commits into from
May 4, 2020
Merged

Update config changes proposal based on CylcCon discussion #90

merged 2 commits into from
May 4, 2020

Conversation

dpmatthews
Copy link
Contributor

@dpmatthews dpmatthews requested review from hjoliver and datamel April 29, 2020 17:57
hjoliver
hjoliver reviewed May 1, 2020
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a couple of comments.

docs/proposal-config-changes.md Show resolved Hide resolved
docs/proposal-config-changes.md Outdated Show resolved Hide resolved
@hjoliver hjoliver force-pushed the master branch 3 times, most recently from e4f52df to 9469743 Compare May 4, 2020 03:45
@hjoliver hjoliver merged commit e82f36f into cylc:master May 4, 2020
@dpmatthews dpmatthews deleted the config-changes-proposal-updates branch May 5, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders left review comments

@hjoliver hjoliver hjoliver approved these changes

@datamel datamel datamel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dpmatthews @hjoliver @oliver-sanders @datamel