Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodocument post-install plugins #236

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Autodocument post-install plugins #236

merged 2 commits into from
Apr 29, 2021

Conversation

MetRonnie
Copy link
Member

Document the new log_vc_info post-install plugin (cylc/cylc-flow#4142)

@MetRonnie MetRonnie added the content Addition or modification of documentation label Apr 6, 2021
@MetRonnie MetRonnie self-assigned this Apr 6, 2021
Post-Install Plugins
====================

.. automodule:: cylc.flow.post_install
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failure seems to be due to google-style docstrings. But actually, I don't think we need the Python functions documented at all? Surely we just need the module docstring? Is there a way to do that?

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Napoleon was not enabled on this repo, not sure why. One line change to enable it - https://github.com/metomi/rose/blob/380315e4785b7319ad3b73d985afbcd2fad858fe/sphinx/conf.py#L38

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I add Napoleon, I start getting errors, possibly because we need https://github.com/agronholm/sphinx-autodoc-typehints

But I guess this isn't needed for this PR, as I've removed the documenting of the log_vc_info members anyway

@MetRonnie MetRonnie marked this pull request as ready for review April 22, 2021 15:03
@MetRonnie MetRonnie marked this pull request as draft April 22, 2021 15:05
@MetRonnie
Copy link
Member Author

Will undraft when cylc/cylc-flow#4142 is merged

@oliver-sanders
Copy link
Member

Docs build with no errors, could do with some more info in the docs - https://github.com/cylc/cylc-flow/pull/4142/files#r620134018

@MetRonnie MetRonnie closed this Apr 28, 2021
@MetRonnie MetRonnie reopened this Apr 28, 2021
@MetRonnie MetRonnie marked this pull request as ready for review April 28, 2021 16:08
@MetRonnie MetRonnie requested a review from wxtim April 28, 2021 16:09
@MetRonnie
Copy link
Member Author

The only test failure is the tutorial suite

@wxtim wxtim merged commit eaa6df2 into cylc:master Apr 29, 2021
@MetRonnie MetRonnie deleted the log-vc-info branch April 29, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Addition or modification of documentation small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants