-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autodocument post-install plugins #236
Conversation
src/plugins/post-install/index.rst
Outdated
Post-Install Plugins | ||
==================== | ||
|
||
.. automodule:: cylc.flow.post_install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to do that?
https://github.com/cylc/cylc-flow/pull/4142/files#r607893197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like Napoleon was not enabled on this repo, not sure why. One line change to enable it - https://github.com/metomi/rose/blob/380315e4785b7319ad3b73d985afbcd2fad858fe/sphinx/conf.py#L38
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I add Napoleon, I start getting errors, possibly because we need https://github.com/agronholm/sphinx-autodoc-typehints
But I guess this isn't needed for this PR, as I've removed the documenting of the log_vc_info
members anyway
Will undraft when cylc/cylc-flow#4142 is merged |
Docs build with no errors, could do with some more info in the docs - https://github.com/cylc/cylc-flow/pull/4142/files#r620134018 |
The only test failure is the tutorial suite |
Document the new
log_vc_info
post-install plugin (cylc/cylc-flow#4142)