update cylc_lang extension #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference this diff is the last commit of metomi/rose#2274 |
kinow
approved these changes
Jul 29, 2019
There was a problem hiding this comment.
Using @sadielbartholomew 's screenshot from #38, this was the result of building the docs:
I just checked out this branch, installed it in a clean venv, and did a make clean html singlehtml. This is the result:
Looks good to me. Leaving final review now for @sadielbartholomew 👍
Thanks
sadielbartholomew
approved these changes
Jul 30, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address syntax highlighting part of #38 (review).
Turns out that the
cylc_langextension in cylc-doc had got out of date with the one in rose.The cylc-doc repository should be seen as the canonical location for Cylc Sphinx extensions. In the future we may remove it from Rose and find some way to import it from cylc-doc.