don't display bad practice #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Friend of metomi/rose#2783
I assume you mean cylc/cylc-flow#6137
|
Actually, could be worth explicitly mentioning using |
|
@MetRonnie - Added a warning |
MetRonnie
reviewed
Jun 21, 2024
Rearrange execution time limit admonition
MetRonnie
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Friend of metomi/rose#2783
We shouldn't do anything to encourage using directives equivalent to execution time limit.
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.