Address PR review comments.

cylc · Oct 13, 2021 · 548583f · 548583f
1 parent 5887383
commit 548583f
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 10 deletions.
diff --git a/cylc/flow/flow_mgr.py b/cylc/flow/flow_mgr.py
@@ -16,13 +16,11 @@
 
 """Manage flow counter and flow metadata."""
 
-from typing import Dict, Set, TYPE_CHECKING
+from typing import Dict, Set
 import datetime
 
 from cylc.flow import LOG
-
-if TYPE_CHECKING:
-    from cylc.flow.workflow_db_mgr import WorkflowDatabaseManager
+from cylc.flow.workflow_db_mgr import WorkflowDatabaseManager
 
 
 class FlowMgr:
@@ -54,7 +52,9 @@ def get_new_flow(self, description: str = "no description") -> int:
             self.counter,
             self.flows[self.counter]
         )
-        self.db_mgr.put_workflow_params_1("flow_counter", self.counter)
+        self.db_mgr.put_workflow_params_1(
+            WorkflowDatabaseManager.KEY_FLOW_COUNTER,
+            self.counter)
         return self.counter
 
     def load_flows_db(self, flow_nums: Set[int]) -> None:

diff --git a/cylc/flow/scheduler.py b/cylc/flow/scheduler.py
@@ -947,7 +947,7 @@ def command_poll_tasks(self, items=None):
             [
                 itask
                 for itask in itasks
-                if itask.state(*TASK_STATUSES_ACTIVE, TASK_STATUS_FAILED)
+                if itask.state(*TASK_STATUSES_ACTIVE)
             ]
         )
         return len(bad_items)

diff --git a/cylc/flow/scripts/set_outputs.py b/cylc/flow/scripts/set_outputs.py
@@ -18,8 +18,7 @@
 
 """cylc set-outputs [OPTIONS] ARGS
 
-Tell the scheduler that specified (or "succeeded", by default) outputs
-of tasks are complete.
+Set specified task outputs ("succeeded" by default) to complete.
 
 Downstream tasks will be spawned or updated just as if the outputs were
 completed normally.

diff --git a/cylc/flow/task_job_mgr.py b/cylc/flow/task_job_mgr.py
@@ -773,8 +773,7 @@ def _manip_task_jobs_callback(
                         # Note this catches KeyError too.
                         LOG.warning(
                             'Unhandled %s output: %s', ctx.cmd_key, line)
-                        # TODO - this looks like an uncaught error, in the log:
-                        LOG.exception(exc)
+                        LOG.warning(str(exc))
         # Task jobs that are in the original command but did not get a status
         # in the output. Handle as failures.
         for key, itask in sorted(bad_tasks.items()):