Response to review

- Variable name suggestions.
- Test speedup.

cylc/flow/config.py

@@ -690,7 +690,7 @@ def process_initial_cycle_point(self) -> None:
         Sets:
             self.initial_point
             self.cfg['scheduling']['initial cycle point']
-            self.raw_icp
+            self.evaluated_icp
         Raises:
             WorkflowConfigError - if it fails to validate
         """

cylc/flow/workflow_db_mgr.py

@@ -329,7 +329,7 @@ def put_workflow_params(self, schd: 'Scheduler') -> None:
         ])
 
         # Retrieve raw initial cycle point stored on the config.
-        value = getattr(schd.config, 'raw_icp', None)
+        value = getattr(schd.config, 'evaluated_icp', None)
         value = None if value == 'reload' else value
         self.put_workflow_params_1(self.KEY_INITIAL_CYCLE_POINT, value)
 

tests/functional/cylc-combination-scripts/09-vr-icp-now.t

@@ -35,4 +35,5 @@ run_ok "${TEST_NAME_BASE}-vip" \
 echo "# Some Comment" >> flow.cylc
 
 run_ok "${TEST_NAME_BASE}-vr" \
-    cylc vr "${WORKFLOW_ID}"
+    cylc vr "${WORKFLOW_ID}" \
+        --stop-cycle-point 2020-01-01T00:02Z

tests/functional/cylc-combination-scripts/09-vr-icp-now/flow.cylc

@@ -1,7 +1,9 @@
 [scheduling]
-    initial cycle point = now
+    initial cycle point = 2020
+    stop after cycle point = 2020-01-01T00:01Z
     [[graph]]
         PT1M = foo
 [runtime]
     [[foo]]
-        script = cylc stop "${CYLC_WORKFLOW_ID}"
+        [[[simulation]]]
+            default run length = PT0S