Skip to content

Commit

Permalink
Ensure that platform from group selection checks broadcast manager
Browse files Browse the repository at this point in the history
for updates to task config.
Ensure that 255 callback gives a sensible platform in warning messages.
  • Loading branch information
wxtim committed Aug 27, 2024
1 parent 347921f commit bde2903
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions cylc/flow/subprocpool.py
Original file line number Diff line number Diff line change
Expand Up @@ -557,12 +557,12 @@ def _run_callback(callback, args_=None):
# Backup, get a platform name from the config:
for arg in callback_args:
if isinstance(arg, TaskProxy):
platform_name = arg.tdef.rtconfig['platform']
platform_name = arg.platform['name']

Check warning on line 560 in cylc/flow/subprocpool.py

View check run for this annotation

Codecov / codecov/patch

cylc/flow/subprocpool.py#L560

Added line #L560 was not covered by tests
elif (
isinstance(arg, list)
and isinstance(arg[0], TaskProxy)
):
platform_name = arg[0].tdef.rtconfig['platform']
platform_name = arg[0].platform['name']

if cls.ssh_255_fail(ctx) or cls.rsync_255_fail(ctx, platform) is True:
# Job log retrieval passes a special object as a command key
Expand Down
6 changes: 4 additions & 2 deletions cylc/flow/task_job_mgr.py
Original file line number Diff line number Diff line change
Expand Up @@ -306,10 +306,12 @@ def submit_task_jobs(self, workflow, itasks, curve_auth,

# Get another platform, if task config platform is a group
use_next_platform_in_group = False
if itask.tdef.rtconfig['platform']:
bc_mgr = self.task_events_mgr.broadcast_mgr
rtconf = bc_mgr.get_updated_rtconfig(itask)
if rtconf['platform']:
try:
platform = get_platform(
itask.tdef.rtconfig['platform'],
rtconf['platform'],
bad_hosts=self.bad_hosts
)
except PlatformLookupError:
Expand Down

0 comments on commit bde2903

Please sign in to comment.