-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mkdir_p.py when moving to Python 3 #2858
Comments
Yep, do it. Not sure if I was unaware of 'os.makedirs' 8 yrs ago, or just hallucinating! Feel free to create useful labels too. |
We should probably create some milestones. E.g.:
|
@hjoliver As @kinow said, Similar logic in Rose can be upgraded too: |
@hjoliver could have suggested that change for Python! |
Yay, glad I was not hallucinating 😁 (and I should have read @kinow 's post more carefully ... am on my phone at the conference). |
@matthewrmshin agreed. We would of course need an agreed & rigorous definition of 'done' & 'ready' in each case, especially where it is not as clear-cut what a finished feature would be (i.e. for the Web UI we will want it to be functional & users to be happy.) I advocate we brush up on our Greek alphabet & break milestones down further than your suggestions, though I realise they were just for illustrative purposes & not a concrete proposal. The breakdown between minor & major milestones is something we should consider carefully, because I don't think we can estimate even crudely relatively how much time & effort these various roadmap goals will take. |
@matthewrmshin You know I'm keen on naming releases up-front i.e. I expect with different people working on different aspects of Cylc it will be very difficult to have fine-grained milestones for the intermediate stages of cylc8. |
@oliver-sanders - we have "next-release" because it often wasn't clear in the past if the next release would be a maintenance release, before the the next minor or major. I suppose an alternative strategy would be always anticipate the next minor release, and then cherrypick bug fixes to an un-advertised maintenance release if necessary. Is that what you'd prefer? |
[note I just corrected "minor" -> "maintenance" in the second sentence above, without which it must have seemed rather nonsensical - sorry!] |
* closes cylc#2858
mkdir_p.py
is almost simply an alias toos.makedirs
, with the only difference being that it suppress theOSError: File exists
error.In Python 3.2+
os.makedirs
takes an extraexist_ok=True
argument to ignore that error. Which means that we can removemkdir_p.py
with no issues as soon as we start working on the Python 3 branch 👍On a side note, I wonder if we could have a label like "Python 3" perhaps? And start documenting what else we have to do, so that we don't forget by the time we start working on it?
The text was updated successfully, but these errors were encountered: