Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pipes.quote by shlex.quote when Py3 #2864

Closed
kinow opened this issue Nov 16, 2018 · 3 comments · Fixed by #2966
Closed

Replace pipes.quote by shlex.quote when Py3 #2864

kinow opened this issue Nov 16, 2018 · 3 comments · Fixed by #2966
Assignees
Labels
Milestone

Comments

@kinow
Copy link
Member

kinow commented Nov 16, 2018

We have from pipes import quote in a few parts of the code. But the pipes module exports in __all__ only Template. The quote method was supposed to be internal, but probably due to it being useful, now it is exported/documented in shlex.quote, but I believe it's Py3 only

So when moving to Py3, 2to3/six/futurize won't alert us about that, and so this ticket as a remainder 😬

@kinow kinow added this to the later milestone Nov 16, 2018
@kinow kinow added the small label Nov 16, 2018
@kinow
Copy link
Member Author

kinow commented Nov 16, 2018

Found this while reviewing #2809 and finding the pipes.quote usage, which was new for me 🤓

@oliver-sanders
Copy link
Member

Python unhelpfully deprecated pipes.quote in 2.7 but diddn't expose it again until 3.3!

@kinow
Copy link
Member Author

kinow commented Nov 16, 2018

Had no idea that that's what happened hahaha. Bet they got a few angry users demanding a replacement

@matthewrmshin matthewrmshin modified the milestones: later, soon Nov 16, 2018
@hjoliver hjoliver mentioned this issue Nov 16, 2018
6 tasks
@oliver-sanders oliver-sanders mentioned this issue Mar 7, 2019
5 tasks
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Mar 7, 2019
@matthewrmshin matthewrmshin modified the milestones: soon, cylc-8.0.0 Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants