Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NameError when invalid cylc command is used (instead of a ValueError) #3173

Closed
kinow opened this issue May 22, 2019 · 0 comments · Fixed by #3174
Closed

NameError when invalid cylc command is used (instead of a ValueError) #3173

kinow opened this issue May 22, 2019 · 0 comments · Fixed by #3174
Assignees
@kinow
Labels
bug Something is wrong :(
Milestone
cylc-8.0a1

Comments

@kinow
Copy link
Member

kinow commented May 22, 2019

Describe the bug

Decided to run a complete analysis in the IDE after reviewing GraphQL changes, and before our monthly meeting. It found one variable that was being used without being initialized anywhere else. I think this happened during work for #3162

image

Release version(s) and/or repository branch(es) affected?

master.

Steps to reproduce the bug

I've added a unit test to cover it, as it wasn't before:

image

But you just need to configure [host][owner]cylc executable = cylc-something to reproduce it.

Expected behavior

It should raise a ValueError, not a NameError.

Screenshots

Attached above.

Additional context
NA

Pull requests welcome!
👍
@kinow kinow added the bug Something is wrong :( label May 22, 2019
@kinow kinow self-assigned this May 22, 2019
@kinow kinow changed the title NameError when invalid cylc command is used NameError when invalid cylc command is used (instead of a ValueError) May 22, 2019
@kinow kinow mentioned this issue May 22, 2019
Merged
5 tasks
@kinow kinow added this to the cylc-8.0a1 milestone May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kinow kinow

Labels
bug Something is wrong :(
Projects
None yet
Milestone
cylc-8.0a1
Development

Successfully merging a pull request may close this issue.

Fix NameError on invalid cylc command kinow/cylc-flow
1 participant
@kinow