Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NameError on invalid cylc command #3174

Merged
merged 1 commit into from
May 22, 2019
Merged

Fix NameError on invalid cylc command #3174

merged 1 commit into from
May 22, 2019

Conversation

kinow
Copy link
Member

@kinow kinow commented May 22, 2019

These changes close #3173

Requirements check-list:

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • My commits have logically grouped changes (use interactive rebase
    to tidy your branch history if necessary).
  • I have not included off-topic changes (use other PRs for these).
  • I have included tests with adequate coverage.
  • I have added an entry in CHANGES.md for next release.

@kinow kinow self-assigned this May 22, 2019
@kinow kinow requested a review from hjoliver May 22, 2019 05:32
@kinow kinow added the bug Something is wrong :( label May 22, 2019
@kinow kinow added this to the cylc-8.0a1 milestone May 22, 2019
@kinow
Copy link
Member Author

kinow commented May 22, 2019

Assigned first review to @hjoliver as I think he worked on that code recently. Happy to have anybody as second reviewer 👍

dwsutherland
dwsutherland approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@dwsutherland dwsutherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dwsutherland dwsutherland merged commit a8e32af into cylc:master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwsutherland dwsutherland dwsutherland approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@kinow kinow

Labels
bug Something is wrong :(
Projects
None yet
Milestone
cylc-8.0a1
Development

Successfully merging this pull request may close these issues.

NameError when invalid cylc command is used (instead of a ValueError)
3 participants
@kinow @hjoliver @dwsutherland