Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove spurious queue add warning #3470

Closed
hjoliver opened this issue Dec 23, 2019 · 3 comments
Closed

Remove spurious queue add warning #3470

hjoliver opened this issue Dec 23, 2019 · 3 comments
Assignees
Labels
bug Something is wrong :(
Milestone

Comments

@hjoliver
Copy link
Member

hjoliver commented Dec 23, 2019

Describe the bug

If a task foo inherits from two families A and B, assigning members of both A and B to a queue will result (on adding the second family) in a warning that foo has already been added to a queue. This is fine if A and B are separately added to different queues, but pointless at best if they are both added to the same queue.

https://cylc.discourse.group/t/suggestion-for-queue-warnings/190

Release version(s) and/or repository branch(es) affected?

7.8.x and current master

Steps to reproduce the bug

(Just reproduce the above scenario in a small workflow definition, then validate it).

Assigning myself as I already put in a quick fix while looking at the problem.

(PR should go to both 7.8.5 and 8.0a2)

@hjoliver hjoliver added the bug Something is wrong :( label Dec 23, 2019
@hjoliver hjoliver added this to the cylc-7.8.5 milestone Dec 23, 2019
@hjoliver hjoliver self-assigned this Dec 23, 2019
@wxtim
Copy link
Member

wxtim commented Mar 27, 2020

@hjoliver Can we get a PR or push this beyond 7.8.5?

@hjoliver
Copy link
Member Author

I'll take a quick look now...

This was referenced Mar 29, 2020
@hjoliver
Copy link
Member Author

Closed by #3539 #3540 #3541

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

No branches or pull requests

2 participants