-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queue warning #3539
Queue warning #3539
Conversation
On 7.8.x:
On this PR branch:
|
78b541e
to
e5d0d98
Compare
Conflicts in |
(just rebased) |
I'll replace the new functional test with a unit test, on the master version of this (once this is approved). |
Note as a follow-on to this change I could change the existing behaviour (as marked Note this is discussed in #2701 along with the possibility of allowing tasks to belong to multiple queues at once, but I don't think we figured out a sensible way of doing that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Functional tests passed 2 out of 4 jobs. Approving assuming the other two (and flakytests) pass (with or without some kicking 🥋 )
for msg in warnings: | ||
err_msg += "\n+ %s" % msg | ||
LOG.warning(err_msg) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This block was wrongly inside the outermost loop, resulting in repeated warnings in some cases)
These changes partially address #3470 (close after PR port to 7.9.x and master as well)
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.Appropriate tests are included (unit and/or functional).
Appropriate change log entry included.
No documentation update required. (No significant change to users, just fewer warnings)