Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tui: improve performance #3527

Closed
oliver-sanders opened this issue Mar 19, 2020 · 5 comments · Fixed by #5731
Closed

tui: improve performance #3527

oliver-sanders opened this issue Mar 19, 2020 · 5 comments · Fixed by #5731
Assignees
@oliver-sanders
Milestone
8.3.0

Comments

@oliver-sanders
Copy link
Member

  • Use a subscription to GraphQL deltas to update the tree.
  • Perform the updates asynchronously so that the app doesn't freeze during the update.

Pull requests welcome!
@oliver-sanders oliver-sanders added this to the cylc-8.0.0 milestone Mar 19, 2020
@oliver-sanders oliver-sanders mentioned this issue Mar 19, 2020
Merged
12 tasks
@oliver-sanders
Copy link
Member Author

What the change to GraphQL deltas means for communications and how it fits into the plan:

rect4117

@oliver-sanders oliver-sanders mentioned this issue Aug 4, 2020
Open
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Feb 26, 2021
@oliver-sanders
tui: add warning about using with large flows
79f1e34 
* cylc#3527
@oliver-sanders oliver-sanders mentioned this issue Feb 26, 2021
Merged
7 tasks
@hjoliver hjoliver added the BLOCKED This can't happen until something else does label Aug 4, 2021
@hjoliver
Copy link
Member

hjoliver commented Aug 4, 2021

Blocked by #3731

@dpmatthews dpmatthews modified the milestones: cylc-8.0.0, cylc-8.x Aug 4, 2021
@oliver-sanders
Copy link
Member Author

Until #3731 we might be able to improve performance by bumping the data update part of Tui into a separate process, decoupling the data provision and UI update.

This approach would still be valid after #3731 so not a bad idea providing it can be done simply. We may be able to compute deltas in the update process paving the way for #3731 too.

@hjoliver
Copy link
Member

Good idea.

@oliver-sanders oliver-sanders modified the milestones: cylc-8.x, cylc-8.3.0 Sep 14, 2023
@oliver-sanders
Copy link
Member Author

The multi-process approach seems to work well enough to close this issue.

@oliver-sanders oliver-sanders mentioned this issue Sep 14, 2023
Merged
12 tasks
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Sep 14, 2023
@oliver-sanders
Tui 1.0
6a35418 
* Move the updater into another process.
  This removes the limitation that caused Tui to crash with active workflows.
  Closes cylc#3527
* Add multi-workflow capability.
  Closes cylc#3464
* Add visual regression testing framework.
  Closes cylc#3530
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Sep 15, 2023
@oliver-sanders
Tui 1.0
8742d5e 
* Move the updater into another process.
  This removes the limitation that caused Tui to crash with active workflows.
  Closes cylc#3527
* Add multi-workflow capability.
  Closes cylc#3464
* Add visual regression testing framework.
  Closes cylc#3530
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Sep 26, 2023
@oliver-sanders
Tui 1.0
83c2915 
* Move the updater into another process.
  This removes the limitation that caused Tui to crash with active workflows.
  Closes cylc#3527
* Add multi-workflow capability.
  Closes cylc#3464
* Add visual regression testing framework.
  Closes cylc#3530
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Sep 26, 2023
@oliver-sanders
Tui 1.0
f0e925a 
* Move the updater into another process.
  This removes the limitation that caused Tui to crash with active workflows.
  Closes cylc#3527
* Add multi-workflow capability.
  Closes cylc#3464
* Add visual regression testing framework.
  Closes cylc#3530
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Oct 2, 2023
@oliver-sanders
Tui 1.0
0fc7f40 
* Move the updater into another process.
  This removes the limitation that caused Tui to crash with active workflows.
  Closes cylc#3527
* Add multi-workflow capability.
  Closes cylc#3464
* Add visual regression testing framework.
  Closes cylc#3530
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Oct 3, 2023
@oliver-sanders
Tui 1.0
e57e4db 
* Move the updater into another process.
  This removes the limitation that caused Tui to crash with active workflows.
  Closes cylc#3527
* Add multi-workflow capability.
  Closes cylc#3464
* Add visual regression testing framework.
  Closes cylc#3530
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Oct 4, 2023
@oliver-sanders
Tui 1.0
2724924 
* Move the updater into another process.
  This removes the limitation that caused Tui to crash with active workflows.
  Closes cylc#3527
* Add multi-workflow capability.
  Closes cylc#3464
* Add visual regression testing framework.
  Closes cylc#3530
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Oct 6, 2023
@oliver-sanders
Tui 1.0
2581571 
* Move the updater into another process.
  This removes the limitation that caused Tui to crash with active workflows.
  Closes cylc#3527
* Add multi-workflow capability.
  Closes cylc#3464
* Add visual regression testing framework.
  Closes cylc#3530
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Oct 12, 2023
@oliver-sanders
Tui 1.0
423e8c8 
* Move the updater into another process.
  This removes the limitation that caused Tui to crash with active workflows.
  Closes cylc#3527
* Add multi-workflow capability.
  Closes cylc#3464
* Add visual regression testing framework.
  Closes cylc#3530
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Oct 13, 2023
@oliver-sanders
Tui 1.0
80f5bd6 
* Move the updater into another process.
  This removes the limitation that caused Tui to crash with active workflows.
  Closes cylc#3527
* Add multi-workflow capability.
  Closes cylc#3464
* Add visual regression testing framework.
  Closes cylc#3530
oliver-sanders added a commit to oliver-sanders/cylc-flow that referenced this issue Oct 13, 2023
@oliver-sanders
Tui 1.0
571b27f 
* Move the updater into another process.
  This removes the limitation that caused Tui to crash with active workflows.
  Closes cylc#3527
* Add multi-workflow capability.
  Closes cylc#3464
* Add visual regression testing framework.
  Closes cylc#3530
@dpmatthews dpmatthews removed the BLOCKED This can't happen until something else does label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliver-sanders oliver-sanders

Labels
None yet
Projects
None yet
Milestone
8.3.0
Development

Successfully merging a pull request may close this issue.

Tui 1.0 oliver-sanders/cylc-flow
3 participants
@dpmatthews @hjoliver @oliver-sanders