Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution polling intervals not set correctly #3706

Closed
dpmatthews opened this issue Jul 23, 2020 · 2 comments
Closed

Execution polling intervals not set correctly #3706

dpmatthews opened this issue Jul 23, 2020 · 2 comments
Labels
bug Something is wrong :(
Milestone

Comments

@dpmatthews
Copy link
Contributor

The execution polling intervals are not set correctly when you specify a list of intervals in combination with an execution time limit.

Example suite:

[scheduling]
    [[dependencies]]
        graph = root
[runtime]
    [[poll]]
        [[[job]]]
            execution polling intervals = PT30S, PT1H
    [[limit]]
        [[[job]]]
            execution time limit = PT30M
    [[limit_poll]]
        [[[job]]]
            execution time limit = PT30M
            execution polling intervals = PT30S, PT1H

Relevant suite log entries:

[poll.1] -health check settings: execution timeout=None, polling intervals=PT30S,PT1H,...

This looks fine.

[limit.1] -health check settings: execution timeout=PT40M, polling intervals=PT31M,PT2M,PT7M,...

This makes sense (although I'm not sure why the execution timeout is set - don't think this is documented anywhere).

[limit_poll.1] -health check settings: execution timeout=PT40M, polling intervals=60*PT30S,PT1M,PT2M,PT7M,...

This is wrong - it looks like only the first item in the execution polling intervals list is being used.

Tested with 7.8.6 & repeated on master.

@dpmatthews dpmatthews added the bug Something is wrong :( label Jul 23, 2020
@dpmatthews dpmatthews added this to the cylc-7.8.x milestone Jul 23, 2020
@hjoliver
Copy link
Member

hjoliver commented Dec 3, 2020

Update: this was giving the right answer for the wrong reasons on current master, but will revert to giving the wrong answer for the right reasons once #3981 is merged.

@dpmatthews
Copy link
Contributor Author

Bug fixed in #4844.
Execution timeout issue moved to #4859.

@dpmatthews dpmatthews modified the milestones: cylc-8.x, cylc-8.0rc3 May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

No branches or pull requests

2 participants