-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set execution polling delays correctly #4844
Conversation
Add polling interval test and change log entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🎉
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final review from me (of change to code base - I have accepted the changes to the test). I have reproduced problem on master to ensure fix works. Merging after CI check.
(checks passed) |
These changes partially address #3706
Tested with this workflow:
Result using master:
e.g. limit10M has
polling intervals=20*PT30S,PT1M,PT2M,PT7M,...
which not what we want.Result using this branch:
e.g. limit10M now has
polling intervals=3*PT30S,PT9M30S,PT2M,PT7M,...
which makes sense.Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
andconda-environment.yml
.