Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cylc clean to work with --force when DB is corrupted/incompatible #4450

Open
MetRonnie opened this issue Oct 5, 2021 · 7 comments
Open
Labels
could be better Not exactly a bug, but not ideal. question Flag this as a question for the next Cylc project meeting. small
Milestone

Comments

@MetRonnie
Copy link
Member

MetRonnie commented Oct 5, 2021

Describe exactly what you would like to see in an upcoming release

Instead of

$ cylc clean temp5 --force
ServiceFileError: Cannot clean - Workflow database is incompatible with Cylc 8.0b3.dev, or is corrupted

we should be able to use --force to force it to clean, possibly with a message similar to when there is no DB, .e.g

INFO - Workflow database is incompatible with Cylc 8.0b3.dev, or is corrupted - will only clean locally

Pull requests welcome!

@MetRonnie MetRonnie added small question Flag this as a question for the next Cylc project meeting. could be better Not exactly a bug, but not ideal. labels Oct 5, 2021
@MetRonnie MetRonnie added this to the cylc-8.0.0 milestone Oct 5, 2021
@MetRonnie
Copy link
Member Author

Marking as a question to bring up on Friday in case there is a reason not to do this

@oliver-sanders
Copy link
Member

Low priority.

@oliver-sanders oliver-sanders modified the milestones: cylc-8.0rc1, cylc-8.x Nov 24, 2021
@MetRonnie
Copy link
Member Author

Every now and then I run into this, which is a bit frustrating. I'd be tempted to promote this to 8.0.0 or rc2

@oliver-sanders
Copy link
Member

How are you getting corrupted DBs?

@MetRonnie
Copy link
Member Author

Not so much corrupted DBs as trying to clean Cylc 7 runs

@oliver-sanders
Copy link
Member

Ah, do we not prohibit cleaning Cylc 7 runs?!

@oliver-sanders
Copy link
Member

For a Cylc 7 workflow you get:

Workflow database is incompatible with Cylc 8.0rc1.dev, or is corrupted

Which is fine. I don't think cylc clean should attempt to remove Cylc 7 workflows, users should continue to use rose suite-clean (which has remote support) or employ whatever local practices they usually use.

We could detect a Cylc 7 workflow and print this advice for clarity?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
could be better Not exactly a bug, but not ideal. question Flag this as a question for the next Cylc project meeting. small
Projects
None yet
Development

No branches or pull requests

2 participants