Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cylc clean: rename --force to --yes #4675

Merged
merged 3 commits into from
Feb 11, 2022
Merged

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Feb 10, 2022

These changes partially address #4673 and #4618

The --force behaviour is more of a --yes than --force, so rename it.

--force can come back later if we want to allow users to override the current "cannot clean" scenarios - see #4450

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Appropriate tests: Add func test for multi clean #4682
  • Appropriate change log entry included.
  • Docs PR: Update cylc clean docs cylc-doc#403

@MetRonnie MetRonnie added this to the cylc-8.0rc1 milestone Feb 10, 2022
@MetRonnie MetRonnie self-assigned this Feb 10, 2022
@oliver-sanders
Copy link
Member

partially address #4673 and #4618

What's left?

@MetRonnie
Copy link
Member Author

The second task on #4673

As for #4618, I've changed the multi workflow clean message

-Would remove the following workflows:
+Would clean the following workflows:

which is better because it doesn't explicitly say the whole run dir will be removed when you're only doing --rm subdir, but it still kinda implies it, so have left the issue open

@oliver-sanders
Copy link
Member

oliver-sanders commented Feb 11, 2022

So closes #4618?

@oliver-sanders oliver-sanders linked an issue Feb 11, 2022 that may be closed by this pull request
@MetRonnie
Copy link
Member Author

MetRonnie commented Feb 11, 2022

I still think the prompt message is a bit alarming for targeted clean, perhaps the prompt could do with a slight rethink later on

@oliver-sanders
Copy link
Member

oliver-sanders commented Feb 11, 2022

I think it's ok, to explain better we would need something like a dry run listing exactly what we would expect to be removed where (perfectly possible though probs a bit OTT).

@oliver-sanders
Copy link
Member

Very small scope, can single review this.

@oliver-sanders oliver-sanders merged commit 0a7e7a6 into cylc:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cylc clean --rm - improve interactive message
2 participants