Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cylc clean docs #403

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Update cylc clean docs #403

merged 1 commit into from
Feb 14, 2022

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Feb 11, 2022 •
edited
Loading

Accompanies cylc/cylc-flow#4675

@MetRonnie MetRonnie added content Addition or modification of documentation small labels Feb 11, 2022
@MetRonnie MetRonnie added this to the 8.0rc1 milestone Feb 11, 2022
@MetRonnie MetRonnie self-assigned this Feb 11, 2022
@MetRonnie MetRonnie mentioned this pull request Feb 11, 2022
Merged
7 tasks
@datamel datamel self-requested a review February 14, 2022 12:01
datamel
datamel approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have built the docs and read the changes. Would it be worth mentioning use case for --yes?

src/user-guide/removing-workflows.rst Outdated Show resolved Hide resolved
@MetRonnie
Copy link
Member Author

I have built the docs and read the changes. Would it be worth mentioning use case for --yes?

I thought about it, but I don't think we need to advertise it any more than --help offers (and anyone running cylc clean in a non-interactive session will get an error message saying use --yes anyway)

@MetRonnie
Copy link
Member Author

Test failure is due to setup.py falling foul of new flake8-simpilify rule, not worth fixing, will open a PR to convert setup.py to setup.cfg anyway

@oliver-sanders oliver-sanders merged commit 3ec1742 into cylc:master Feb 14, 2022
@MetRonnie MetRonnie deleted the cylc-clean branch February 14, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamel datamel datamel approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@MetRonnie MetRonnie

Labels
content Addition or modification of documentation small
Projects
None yet
Milestone
8.0rc1
Development

Successfully merging this pull request may close these issues.
3 participants
@MetRonnie @oliver-sanders @datamel