Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIP: Run Name not handled #5310

Closed
wxtim opened this issue Jan 18, 2023 · 2 comments · Fixed by #5314
Closed

VIP: Run Name not handled #5310

wxtim opened this issue Jan 18, 2023 · 2 comments · Fixed by #5314
Assignees
Labels
bug Something is wrong :(
Milestone

Comments

@wxtim
Copy link
Member

wxtim commented Jan 18, 2023

Describe the bug

If you use the --run-name option with cylc install you have to specify the run name in the ID with cylc play, unlike the numbered runs where cylc assumes you mean the most recent install:

cd ~/cylc-src/foo
cylc vip --run-name bar
...
# validate and install OK
...
WorkflowFilesError: No flow.cylc or suite.rc in /home/h02/tpilling/cylc-run/foo  # It's in foo/bar

Expected behavior

Either

  1. Throw --run-name out from Cylc VIP as an invalid option.
  2. Allow --run-name and modify the workflow id given to Cylc play accordingly.
  3. Modify cylc install and cylc play so that cylc install can mark the last install. cylc play uses marker to infer run-name to use.

Additional context

It might be worth checking various permutations of run-name & no-run-name looking for other bugs like this one.

Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read CONTRIBUTING.md before starting any work though).

@wxtim wxtim added bug Something is wrong :( question Flag this as a question for the next Cylc project meeting. labels Jan 18, 2023
@wxtim wxtim self-assigned this Jan 18, 2023
@wxtim
Copy link
Member Author

wxtim commented Jan 18, 2023

I think number 2 is the correct answer - number 3 is fairly invasive of existing functionality and risks creating other issues. Number one is unnecessarily unhelpful.

@oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders added this to the 8.1.1 milestone Jan 18, 2023
@oliver-sanders oliver-sanders removed the question Flag this as a question for the next Cylc project meeting. label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants