-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Cylc VIP to work with named runs. #5314
Conversation
7324ca1
to
0f3580b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the tests need checking on this one.
|
Could you rebase onto 8.1.x please. |
275d441
to
ae68884
Compare
I haven't been able to replicate this. |
Where name is `workflow` and id is `workflow/runX` or `workflow/name`. mypy fix
ae68884
to
949e38a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot reproduce Oliver's "No flow.cylc or suite.rc in ~/cylc-run/generic"
935c3bd
to
a8ef493
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this need a cylc-rose PR?
I don't think cylc-run uses the changed interfaces, and running the tests suggests that it doesn't. |
Closes #5310
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
andconda-environment.yml
.CHANGES.md
entry included if this is a change that can affect users