Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graph parser: expire-all ? #5354

Closed
oliver-sanders opened this issue Feb 8, 2023 · 5 comments · Fixed by #5658
Closed

graph parser: expire-all ? #5354

oliver-sanders opened this issue Feb 8, 2023 · 5 comments · Fixed by #5658
Assignees
Labels
bug Something is wrong :(
Milestone

Comments

@oliver-sanders
Copy link
Member

The expire-all trigger (valid at Cylc 7) appears to be missing from Cylc 8:

QUAL_FAM_SUCCEED_ALL = "succeed-all"
QUAL_FAM_SUCCEED_ANY = "succeed-any"
QUAL_FAM_FAIL_ALL = "fail-all"
QUAL_FAM_FAIL_ANY = "fail-any"
QUAL_FAM_FINISH_ALL = "finish-all"
QUAL_FAM_FINISH_ANY = "finish-any"
QUAL_FAM_START_ALL = "start-all"
QUAL_FAM_START_ANY = "start-any"
QUAL_FAM_SUBMIT_ALL = "submit-all"
QUAL_FAM_SUBMIT_ANY = "submit-any"
QUAL_FAM_SUBMIT_FAIL_ALL = "submit-fail-all"
QUAL_FAM_SUBMIT_FAIL_ANY = "submit-fail-any"

I'm not sure whether expire-all was "officially supported" or just a side-effect of the way the logic worked, however, it seems like a sensible trigger condition to me. I'm not sure whether its removal was intentional, nothing springs to mind.

At Cylc 8 such a trigger would probably required a ? modifier (as succeeded and expired are orthogonal), but should still work.

Pull requests welcome!

@oliver-sanders oliver-sanders added bug? Not sure if this is a bug or not question Flag this as a question for the next Cylc project meeting. labels Feb 8, 2023
@oliver-sanders oliver-sanders added this to the cylc-8.1.2 milestone Feb 8, 2023
@neill-b
Copy link

neill-b commented Feb 8, 2023

Would be helpful in my use case, so thanks for raising this issue @oliver-sanders.

@hjoliver
Copy link
Member

Even worse: #5364

@oliver-sanders oliver-sanders modified the milestones: cylc-8.1.2, cylc-8.1.3 Feb 16, 2023
@oliver-sanders
Copy link
Member Author

Bumping back until #5364 is sorted.

@oliver-sanders oliver-sanders modified the milestones: cylc-8.1.3, cylc-8.1.x Mar 8, 2023
@hjoliver hjoliver mentioned this issue Mar 16, 2023
8 tasks
@hjoliver hjoliver self-assigned this Mar 16, 2023
@hjoliver hjoliver added bug Something is wrong :( and removed question Flag this as a question for the next Cylc project meeting. bug? Not sure if this is a bug or not labels Mar 16, 2023
@hjoliver hjoliver modified the milestones: cylc-8.1.x, cylc-8.1.3 Mar 16, 2023
@hjoliver
Copy link
Member

PR done, bumping the milestone forward again.

@oliver-sanders oliver-sanders modified the milestones: cylc-8.1.3, cylc-8.1.4 Apr 20, 2023
@oliver-sanders oliver-sanders modified the milestones: cylc-8.1.4, cylc-8.1.x May 4, 2023
@hjoliver hjoliver modified the milestones: cylc-8.1.x, cylc-8.2.0 Jun 13, 2023
@oliver-sanders oliver-sanders modified the milestones: cylc-8.2.0, cylc-8.3.0 Jun 29, 2023
@oliver-sanders
Copy link
Member Author

This can now be attempted, however, won't necessarily work until #5364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants