Fix expire triggers. #5412
Closed
Fix expire triggers. #5412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjoliver
force-pushed
the
expire-trigger
branch
3 times, most recently
from
a21b13d
to
22def64
Compare
Update change log. Add new func test.
hjoliver
force-pushed
the
expire-trigger
branch
from
22def64
to
0f1894b
Compare
1 task
|
Converted back to draft temporarily, in light of today's project meeting. I think have have nailed the expire stall/no-stall situation, and how expire relates to success (etc.) optionality. But I ran out of time to write it up this afternoon. Stand by ... |
|
PR blocked pending resolution of the We will still need the ability to trigger tasks off of task expiry, but I have argued against continuing to treat |
Comment on lines
+745
to
+748
| if output == TASK_OUTPUT_EXPIRED and not optional: | ||
| raise GraphParseError( | ||
| f"Expired-output {name}:{output} must be optional") | ||
|
|
There was a problem hiding this comment.
This is now covered by the optional outputs stuff.
Suggested change
| if output == TASK_OUTPUT_EXPIRED and not optional: | |
| raise GraphParseError( | |
| f"Expired-output {name}:{output} must be optional") |
16 tasks
|
Closing as superseded by #5658 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And require
?(optional) on all expire triggers.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.