Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing execution time limit does not work #5891

Closed
MetRonnie opened this issue Dec 19, 2023 · 3 comments · Fixed by #5902
Closed

Clearing execution time limit does not work #5891

MetRonnie opened this issue Dec 19, 2023 · 3 comments · Fixed by #5902
Assignees
Labels
bug Something is wrong :(
Milestone

Comments

@MetRonnie
Copy link
Member

Description

Clearing the execution time limit either by editing flow.cylc and reloading, or by broadcast/edit-runtime, does not work. The original execution time limit is maintained.

Reproducible Example

# flow.cylc
[scheduling]
    cycling mode = integer
    [[graph]]
        R1 = a
[runtime]
    [[a]]
        script = sleep 10
        execution time limit = PT1S
$ cylc play workflow

Wait for task to fail.

     [[a]]
         script = sleep 10
-        execution time limit = PT1S
$ cylc reload workflow
$ cylc trigger workflow//1/a

Expected Behaviour

The task should succeed now after 10s, but it still fails after 1s

@MetRonnie MetRonnie added the bug Something is wrong :( label Dec 19, 2023
@MetRonnie MetRonnie added this to the cylc-8.2.4 milestone Dec 19, 2023
@wxtim wxtim self-assigned this Jan 3, 2024
@wxtim
Copy link
Member

wxtim commented Jan 3, 2024

I have successfully reproduced, although it took a bit of work. It's worth noting that using the example given might result in a flaky functional test because having a very short ETL may result in an appearance of submission failure, because the ETL can be evaluated before the submission completes.

I was getting an apparent submission, followed by a submission failure on polling the task!

@wxtim
Copy link
Member

wxtim commented Jan 3, 2024

I think I have it - execution time limit = None is entirely valid but this code assumes that it isn't:

        with suppress(TypeError):
            itask.summary[self.KEY_EXECUTE_TIME_LIMIT] = float(
                rtconfig['execution time limit']
            )

@oliver-sanders
Copy link
Member

Closed by #5902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants