Made execution time limit unsettable by reload or broadcast. #5902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
fix.etl-not-unsettable
branch
from
5572775
to
917c9ea
Compare
Formerly a suppress statement was supressing cases when we wanted to set itask.summary['execution time limit'] = None. Added tests.
wxtim
force-pushed
the
fix.etl-not-unsettable
branch
from
917c9ea
to
0b2a1d7
Compare
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
Test broadcast using _prep_submit_task_job rather than _prep_submit_task_job_impl so that the fake broadcast is applied.
oliver-sanders
approved these changes
Jan 4, 2024
hjoliver
reviewed
Jan 9, 2024
Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
markgrahamdawson
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5891
Formerly a suppress statement was supressing cases when we wanted to set itask.summary['execution time limit'] = None.
Added tests.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect usersCylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.Not req'd?.?.xbranch.