Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphParseError does not print name of non-family namespace that caused error #6331

Closed
uwagura opened this issue Aug 27, 2024 · 1 comment
Closed
Assignees
Labels
bug Something is wrong :(
Milestone

Comments

@uwagura
Copy link
Contributor

uwagura commented Aug 27, 2024

Description

In version 8.3.3 of cylc, GraphParseError does not include the name of the namespace that produced the error

Reproducible Example

Run a command like cylc graph . on the following workflow:

[scheduling]
    [[graph]]
            R1 = "prep => not-fam:succeed-all => final"
[runtime]
    [[prep]]
    [[not-fam]]
    [[final]]

Expected Behaviour

The above workflow will give you an error that says

GraphParseError: family trigger on non-family namespace {expr}

When I believe that it should say

GraphParseError: family trigger on non-family namespace not-fam

I think this error is just caused by a missing f in the following format string. Although it is a small issue, I thought I'd let the development team know just in case the issue occurs in other places as well.

# Not a family.
if trig in self.__class__.fam_to_mem_trigger_map:
raise GraphParseError(
"family trigger on non-family namespace {expr}")

@uwagura uwagura added the bug Something is wrong :( label Aug 27, 2024
@uwagura uwagura mentioned this issue Aug 28, 2024
8 tasks
@oliver-sanders oliver-sanders added this to the 8.3.4 milestone Aug 28, 2024
@oliver-sanders
Copy link
Member

Closed by #6332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

No branches or pull requests

2 participants