Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added f to format string #6332

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

uwagura
Copy link
Contributor

@uwagura uwagura commented Aug 28, 2024

Closes #6331 . Test not needed because I literally just added a character
Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders oliver-sanders added this to the 8.3.4 milestone Aug 28, 2024
@oliver-sanders oliver-sanders added the bug Something is wrong :( label Aug 28, 2024
@oliver-sanders
Copy link
Member

oliver-sanders commented Aug 28, 2024

Hi @uwagura and welcome to the Cylc community 🎉

Thanks for your bug report and many thanks for taking the time to fix the issue.

For legal reasons, we need all commit authors to enter their names into the CONTRIBURINTING.md file (no matter how small the fix) in order to agree to the CLA.

Make sure you write your name in the same format it appears in your commit (run git shortlog -se and copy your name as it appears there, or add an entry into the .mailmap file if you want it to appear differently).

(happy to forgo a changelog entry for this fix)

@uwagura
Copy link
Contributor Author

uwagura commented Aug 29, 2024

@oliver-sanders , feels a bit strange to call myself a contributor for such a small change, but I've gone ahead and added myself to the contributors list and mailmap. I also added an entry to the changelog using towncrier, though I'm not entirely sure if I did it correctly. Let me know how how everything looks

@oliver-sanders
Copy link
Member

It's a legal thing we have to do even with the smallest commits, we only need to do it once.

We greatly appreciate bugfixes, thanks for your contribution.

@oliver-sanders oliver-sanders merged commit c6076c0 into cylc:8.3.x Aug 29, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants