-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GUI browse URL improvements #2449
Conversation
@matthewrmshin - in light of recent emails - I should add to the documentation on this PR, about the effect of a shared filesystem between GUI host and suite daemon host. My new section on the GUI and ssh is for the non-shared case. |
In the future, we should modify the GUI so that all relevant commands are accessed though the API of the running suite (with the exception for suites running on |
Yes and no - some of the current GUI functionality could not easily be done that way, e.g. edit the suite definition! (But we could decide that's not what the GUI is for, I guess). The other concern is, do we want huge suite or job logs being served up by the suite daemon? |
Not easy, but possible. Imagine a work flow like this:
On large files, I am not sure what the impact would be on the suite, but I would imagine that it is no different from how Rose Bush serves log files via cherrypy. |
Fair enough, it certainly is possible. For the future web GUI, we should either do that or drop these functions of the current GUI. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK in general. Worth adding some doc strings to new and modified methods in cylc.gui.app_gcylc
.
8394e9a
to
309b2ab
Compare
Updated docs for the shared filesystem case, added some doc strings, and rebased to master. Hopefully this is good to go now. |
A user reminded me that browsing suite and task URLs from the GUI does not work if (a) the GUI is not running on the suite host account; and (b) the GUI account does not have non-interactive ssh access to the suite host account. Reason: the GUI simply invokes the
cylc doc
/cylc browse
command, which parses the suite definition - which can't be done from a remote account with no non-interactive ssh access to the suite host account.Main change in this PR:
Also: