Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filter for security warnings from urllib3 #2688

Merged
merged 4 commits into from
Jun 25, 2018
Merged

Add filter for security warnings from urllib3 #2688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b56f477
Add filter for security warnings from urllib3
matthewrmshin Jun 5, 2018
8c799c3
Restrict urllib3 warnings filter to <2.7.9
matthewrmshin Jun 6, 2018
003b9c7
cug: improve statement on python 2 requirement
matthewrmshin Jun 7, 2018
5191663
cug: improve statement on Linux requirement
matthewrmshin Jun 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions doc/src/cylc-user-guide/cug.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,12 +381,16 @@ \section{Cylc Screenshots}
\section{Installation}
\label{Requirements}

Cylc runs on Unix variants, usually Linux, and including Apple OS X.
Cylc runs on Linux. It is tested quite thoroughly on modern RHEL and Ubuntu
distros. Some users have also managed to make it work on other Unix variants
including Apple OS X, but they are not officially tested and supported.

\subsection{Third-Party Software Packages}

{\bf Python \lstinline@>=@ 2.6} is required (but not yet Python 3). Python
should already be installed in your Linux system. \url{https://python.org}.
{\bf Python 2 \lstinline@>=@ 2.6} is required.
{\bf Python 2 \lstinline@>=@ 2.7.9} is recommended for the best security.
Python 2 should already be installed in your Linux system.
\url{https://python.org/}.

For Cylc's HTTPS communications layer:
\begin{myitemize}
Expand Down
11 changes: 9 additions & 2 deletions lib/cylc/network/httpclient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,8 +385,15 @@ def call_server_impl(self, url, method, payload):
def _call_server_impl_requests(self, url, method, payload):
"""Call server with "requests" library."""
import requests
from requests.packages.urllib3.exceptions import InsecureRequestWarning
warnings.simplefilter("ignore", InsecureRequestWarning)
# Filter security warnings from urllib3 on python <2.7.9. Obviously, we
# want to upgrade, but some sites have to run cylc on platforms with
# python <2.7.9. On those platforms, these warnings serve no purpose
# except to annoy or confuse users.
if sys.version_info < (2, 7, 9):
from requests.packages.urllib3.exceptions import (
SecurityWarning, SNIMissingWarning)
warnings.simplefilter("ignore", SecurityWarning)
warnings.simplefilter("ignore", SNIMissingWarning)
if self.session is None:
self.session = requests.Session()

Expand Down