Fix InsecureRequestWarning when using anonymous access #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we need to apply this fix to a new |
hjoliver
reviewed
Jul 4, 2018
|
(Presumably Matt means an "else branch" in the code block sense, not a git branch...) |
|
Yes. I meant an else block. |
|
OK on re-test. |
matthewrmshin
approved these changes
Jul 6, 2018
Merged
hjoliver
approved these changes
Jul 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cylc scan & cylc ping connect to suites using the user
anonand usingverify=False.As a result of #2688, we now get
InsecureRequestWarningwarnings from urllib3 with these commands with python versions >= 2.7.9.Also, rather than filter
SecurityWarning(with python versions <2.7.9), we should filterInsecurePlatformWarning(the specific warning which was the problem in #2686).Fix #2713.