Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified images for documentation to match text #2874

Merged
merged 1 commit into from
Nov 21, 2018
Merged

modified images for documentation to match text #2874

merged 1 commit into from
Nov 21, 2018

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Nov 21, 2018

Fix #2747
I've not done one of these before, so I won't worry if you tell me that the format of the diagrams (which I created with Cylc Graph) is wrong.

@wxtim
Copy link
Member Author

wxtim commented Nov 21, 2018

I've created new files using cylc graph. They look rather different to the existing ones, but are consistent with what the users will see.

@hjoliver
Copy link
Member

They look rather different to the existing ones, ...

It's only the node shape (box vs ellipse) that differs, isn't it?

@matthewrmshin matthewrmshin added this to the soon milestone Nov 21, 2018
@wxtim
Copy link
Member Author

wxtim commented Nov 21, 2018 •
edited
Loading

It's only the node shape (box vs ellipse) that differs, isn't it?

Yes

@matthewrmshin
Copy link
Contributor

@hjoliver please review or reassign?

hjoliver
hjoliver approved these changes Nov 21, 2018
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wxtim ; one review will do for this.

@hjoliver hjoliver merged commit acc1a76 into cylc:master Nov 21, 2018
@hjoliver hjoliver modified the milestones: soon, next release Nov 21, 2018
@wxtim wxtim deleted the C2747_documentation_fix branch November 22, 2018 09:03
@oliver-sanders oliver-sanders mentioned this pull request Nov 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver hjoliver approved these changes

Assignees

@wxtim wxtim

Labels
None yet
Projects
None yet
Milestone
cylc-7.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wxtim @hjoliver @matthewrmshin