Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit removes source map from bootstrap CSS. The source map is used by browsers to display the original source-code for users browsing the minified CSS - https://blog.teamtreehouse.com/introduction-source-maps
This fixes this warning in the browser console for users. If, instead, we decided to ship a CSS source map (which is included in Bootstrap distro) we would have to include the source. So a user browsing with Firefox, looking at the stylesheet, would end up requesting other less/css files which we are not including anyway.
The second commit adds a space so that the element's attributes are not concatenated by accident (I believe it happens as the attribute is within an
if
statement, so maybe Jinja strips/trims the content).To test it:
task jobs list
for a valid suite (e.g. five)a
items aroud<!-- entry: logs -->
Firefox is able to correct the formatting, and the link still works. But can't tell whether it will work on other browsers. So sounds like a simple fix for later.
The third commit removes an extra
body
HTML tag.Happy to drop any of the commits in the PR if necessary (that's why organized them in separated ones).
Cheers
Bruno
ps: quite useful Cylc review! Looking forward to the next release!