Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for cylc-review #2881

Merged
merged 3 commits into from
Nov 26, 2018
Merged

Conversation

kinow
Copy link
Member

@kinow kinow commented Nov 26, 2018

The first commit removes source map from bootstrap CSS. The source map is used by browsers to display the original source-code for users browsing the minified CSS - https://blog.teamtreehouse.com/introduction-source-maps

This fixes this warning in the browser console for users. If, instead, we decided to ship a CSS source map (which is included in Bootstrap distro) we would have to include the source. So a user browsing with Firefox, looking at the stylesheet, would end up requesting other less/css files which we are not including anyway.

screenshot_2018-11-26_14-26-34

The second commit adds a space so that the element's attributes are not concatenated by accident (I believe it happens as the attribute is within an if statement, so maybe Jinja strips/trims the content).

To test it:

  • Go to cylc-review
  • Search for a valid user (e.g. kinow)
  • Click on task jobs list for a valid suite (e.g. five)
  • Choose a task (e.g. bar)
  • Open the source code in Firefox (or another editor/browser). Search for the a items aroud <!-- entry: logs -->

screenshot_2018-11-26_15-46-32

Firefox is able to correct the formatting, and the link still works. But can't tell whether it will work on other browsers. So sounds like a simple fix for later.

The third commit removes an extra body HTML tag.

Happy to drop any of the commits in the PR if necessary (that's why organized them in separated ones).

Cheers
Bruno

ps: quite useful Cylc review! Looking forward to the next release!

@kinow kinow added this to the later milestone Nov 26, 2018
@kinow kinow self-assigned this Nov 26, 2018
@kinow kinow changed the title Trivial fixes cylc review Small fixes for cylc-review Nov 26, 2018
@kinow kinow added the small label Nov 26, 2018
@hjoliver hjoliver modified the milestones: later, next release Nov 26, 2018
@matthewrmshin
Copy link
Contributor

One reviewer good enough.

@matthewrmshin matthewrmshin merged commit c06445c into cylc:master Nov 26, 2018
@kinow kinow deleted the trivial-fixes-cylc-review branch March 14, 2019 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants