Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WSGI docs (s/rose/cylc) #2889

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Fix WSGI docs (s/rose/cylc) #2889

merged 1 commit into from
Nov 27, 2018

Conversation

kinow
Copy link
Member

@kinow kinow commented Nov 26, 2018

A PR, but also a question. Should it be rose in the instructions for setting up Apache httpd + Cylc Review, or should it be cylc now?

@kinow kinow added the small label Nov 26, 2018
@kinow kinow added this to the soon milestone Nov 26, 2018
@hjoliver
Copy link
Member

Good spotting, it should be cylc now. We should get this in next release ... tomorrow, as I'd like confirmation of this change from @sadielbartholomew

@kinow
Copy link
Member Author

kinow commented Nov 27, 2018

Had left post-it left on my desk for it after playing with Cylc Review yesterday I think. Assigned @sadielbartholomew as I think she ported the docs, but happy if anybody else review/merges it.

No more pull requests coming from me, have closed my IDE, now doing some JavaScript development & training :) Thanks!

@hjoliver hjoliver modified the milestones: soon, next release Nov 27, 2018
@hjoliver
Copy link
Member

No more pull requests coming from me, have closed my IDE, ...

All good, but see my off-topic question above! (packaging and lib locations)

@kinow
Copy link
Member Author

kinow commented Nov 27, 2018

I think you spotted a problem in my PR! The PYTHONPATH probably should be <cylc dir>/lib

@kinow
Copy link
Member Author

kinow commented Nov 27, 2018

(branch updated, now it's just lib, without the python part)

@kinow kinow self-assigned this Nov 27, 2018
sadielbartholomew
sadielbartholomew reviewed Nov 27, 2018
View reviewed changes
Copy link
Collaborator

@sadielbartholomew sadielbartholomew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ignore - amended]

sadielbartholomew
sadielbartholomew approved these changes Nov 27, 2018
View reviewed changes
Copy link
Collaborator

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted! Missed this when I was converting Rose references to Cylc for the lift-and-shift.

@hjoliver hjoliver merged commit 956fdfc into cylc:master Nov 27, 2018
@sadielbartholomew sadielbartholomew mentioned this pull request Jan 15, 2019
Merged
4 tasks
@kinow kinow deleted the fix-wsgi-doc branch March 14, 2019 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew approved these changes

@hjoliver hjoliver hjoliver approved these changes

Assignees

@kinow kinow

Labels
small
Projects
None yet
Milestone
cylc-7.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kinow @hjoliver @sadielbartholomew