cylc.hostuserutil: get_fqdn_by_host: include bad host name in error #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthewrmshin - I just saw this - do you want to try to get it in 7.8.0? |
|
@hjoliver Up to you! |
hjoliver
reviewed
Nov 27, 2018
| self.assertFalse(is_remote_host(None)) | ||
| self.assertFalse(is_remote_host('localhost')) | ||
| self.assertFalse(is_remote_host(os.getenv('HOSTNAME'))) | ||
| self.assertFalse(is_remote_host(get_host())) | ||
|
|
||
| def test_get_fqdn_by_host_on_bad_host(self): | ||
| """get_fqdn_by_host bad host.""" | ||
| bad_host = 'nosuchhost.nosuchdomain.org' |
There was a problem hiding this comment.
Damn it, I was planning to name my next computer like this.
hjoliver
approved these changes
Nov 27, 2018
|
Matt, if you can get another Northern Hemisphere review on this, I'll merge it and make the release first thing in the morning (without needing to wait on Bruno). Over 'n out 🌙 |
kinow
approved these changes
Nov 27, 2018
|
Approved, but will leave merge up to Hilary when he's preparing the release. Time to hit the sack now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On failure of
socket.gethostbyname_ex, add bad host name to error.Fix #2875.