-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obsolete archane functionality #2936
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove the 5to6 tests?
I'll add most of the suite run database restart upgrade logic. |
Great idea @oliver-sanders !!! 🎉 |
0f86bb8
to
ed95397
Compare
(Just a few failed tests to sort out. You are almost there.) |
Honestly surprised we had tests for the A few tests left to fix. |
64052dc
to
a907e90
Compare
There's also a "Cylc 6 Migration" section in the User Guide. |
a907e90
to
a4fecde
Compare
I think it's probably safer to remove functional configurations rather than obsoleting them so that suites refuse to run rather than run with potentially important bits (e.g. script) missing. @cylc/core With the exception of the renamed metadata entries all the newly obsoleted configurations are functional so should we just remove them instead? |
Agreed. Fail is better than warning in this case. Warnings are just ignored and can cause downstream issues. With the time scale of Cylc 8, we should really aim to provide back compat only for modern Cylc 7 suites. I'd like to draw a line at 7.7 - but happy to stretch it to 7.5. |
There's some old syntax in |
a802269
to
d130ccd
Compare
Test failing on style. |
d130ccd
to
56d0273
Compare
I guess you mean |
It would make sense to remove cruft and cut down the codebase before we spin up major work on Cylc 8 to make things simpler:
As the communication protocols are changing we can now drop all back-compat on the network side.
@cylc/core anything controversial, anything missed?