Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete archane functionality #2936

Merged
merged 12 commits into from
Feb 4, 2019
Merged

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Jan 30, 2019

It would make sense to remove cruft and cut down the codebase before we spin up major work on Cylc 8 to make things simpler:

  • Part 1 - Remove obsolete commands and modules
  • Part 2 - Remove obsolete Cylc configuration & documentation
  • Part 3 - Remove outdated back-compat code branches - future work

As the communication protocols are changing we can now drop all back-compat on the network side.

@cylc/core anything controversial, anything missed?

@oliver-sanders oliver-sanders added this to the cylc-8.0.0 milestone Jan 30, 2019
@oliver-sanders oliver-sanders self-assigned this Jan 30, 2019
Copy link
Contributor

@matthewrmshin matthewrmshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove the 5to6 tests?

tests/cylc-5to6/00-simple-start-up.t Outdated Show resolved Hide resolved
@matthewrmshin
Copy link
Contributor

I'll add most of the suite run database restart upgrade logic.

@kinow
Copy link
Member

kinow commented Jan 30, 2019

Great idea @oliver-sanders !!! 🎉

@matthewrmshin
Copy link
Contributor

(Just a few failed tests to sort out. You are almost there.)

@oliver-sanders
Copy link
Member Author

oliver-sanders commented Jan 31, 2019

Honestly surprised we had tests for the cylc documentation command.

A few tests left to fix.

@hjoliver
Copy link
Member

hjoliver commented Feb 1, 2019

There's also a "Cylc 6 Migration" section in the User Guide.

@oliver-sanders
Copy link
Member Author

I think it's probably safer to remove functional configurations rather than obsoleting them so that suites refuse to run rather than run with potentially important bits (e.g. script) missing.

@cylc/core With the exception of the renamed metadata entries all the newly obsoleted configurations are functional so should we just remove them instead?

@matthewrmshin
Copy link
Contributor

Agreed. Fail is better than warning in this case. Warnings are just ignored and can cause downstream issues. With the time scale of Cylc 8, we should really aim to provide back compat only for modern Cylc 7 suites. I'd like to draw a line at 7.7 - but happy to stretch it to 7.5.

@oliver-sanders
Copy link
Member Author

There's some old syntax in etc/dev-bin. Are these files used any more?

@matthewrmshin
Copy link
Contributor

Test failing on style.

@hjoliver
Copy link
Member

hjoliver commented Feb 4, 2019

There's some old syntax in etc/dev-bin. Are these files used any more?

I guess you mean defn-order-test.py; that could be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants