Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links for cylc-7.8.1 change log entry #2942

Merged
merged 1 commit into from
Feb 11, 2019

Conversation

sadielbartholomew
Copy link
Collaborator

I've just noticed that the version 7.8.1 entry in the change log contains links to PRs/Issues which are all broken due to a consistent foreign # symbol. This fixes all links, as from a grep on /# there are no further identical instances across the entire change log.

[Trivial hence lone reviewer sufficient.]

@sadielbartholomew sadielbartholomew added this to the soon milestone Feb 5, 2019
@sadielbartholomew sadielbartholomew self-assigned this Feb 5, 2019
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks Sadie. Result of careless use of a "recorded" macro in vim, I think, to copy the link text (left) to the URL (right).

@hjoliver
Copy link
Member

@sadielbartholomew - can you replicate this as a PR to the 7.8.x branch, please?

@hjoliver hjoliver merged commit a2dd215 into cylc:master Feb 11, 2019
@hjoliver hjoliver mentioned this pull request Feb 11, 2019
@matthewrmshin matthewrmshin modified the milestones: soon, next-release Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants