Fix issue #2898: close app nicely on CTRL+C #2985
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request was ready over 3 hours ago. But Travis kept failing with flaky tests. Kicked it four times (finish a chapter in some book, come back and check Travis). This would be really off-putting to new contributors 😢 But finally Travis is happy 🎉 |
matthewrmshin
approved these changes
Mar 11, 2019
|
(Not sure if you can re-target this PR to point to the 7.8.x branch or not. If not, I'll just incorporate that into the cherry-picks of #2947.) |
|
@matthewrmshin , can't re-target I think, but checked out the Or if it's easier for you to cherry-pick in #2947, all good for me. |
|
Consider it done. Thanks @matthewrmshin ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2898 .
Encloses GTK main loop in a try/catch, to wait for
KeyboardInterruptand quit nicely.Another workaround is to use
CTRL + \, which sendsSIGKILL, but not a well known short-cut (nor really nice/polite to goSIGKILLing processes around 😬Tested locally, but alas going with no unit/functional tests, so Codecov won't be happy.
Bruno