Extend ZMQClient and update docstrings #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinow
force-pushed
the
inherit-zmqclient
branch
3 times, most recently
from
e5de55d
to
8106477
Compare
| try: | ||
| contact = SuiteSrvFilesManager().load_contact_file( | ||
| suite, owner, host) | ||
| except SuiteServiceFileError: | ||
| sys.exit(cls.NOT_RUNNING % suite) |
There was a problem hiding this comment.
This was a hangover from before #2995, thanks for fixing!
oliver-sanders
approved these changes
May 2, 2019
dwsutherland
approved these changes
May 3, 2019
|
Thanks @dwsutherland , fixing the conflicted file in a bit. |
|
Done, now Travis should be busy re-building it for a few minutes 👍 |
|
(Doubly approved. Merge.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative fix for #3014
Simply makes
SuiteRuntimeClientchild ofZMQClient, and call its constructor. Also updates docstrings, adds PEP-484 notation, and a TODO about a function that exits the program.I remembered about this issue last week while working on the
setup.pyissue (#2989), as I noticed a couple warnings in Codacy that I think may disappear with this change too.Travis-CI passed on my fork, but still pending Codacy inspection 👍