Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move documentation to new cylc/cylc-doc repo. #3181

Merged
merged 4 commits into from
Jun 13, 2019

Conversation

hjoliver
Copy link
Member

These changes close #3180.

Removes entire content of doc directory (moved to cylc/cylc-doc) and adjust setup.py and travis config accordingly.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • These changes are already covered by existing tests.
  • Includes an appropriate entry in the release change log CHANGES.md.
  • I have opened a corresponding documentation PR at Transfer docs from cylc-flow repo. cylc-doc#3.

Marking as a Draft in case this is controversial - however I'm pretty sure we have discussed and agreed this elsewhere. The cylc-8 user guide needs to span multiple cylc components, not just cylc/cylc-flow.

@hjoliver hjoliver self-assigned this May 26, 2019
@hjoliver hjoliver marked this pull request as ready for review June 12, 2019 11:01
@hjoliver
Copy link
Member Author

Branch rebased, post minor doc update on master (which I've transferred to the companion PR on cylc/cylc-doc.

Can we get these merged, as they are a serious impediment to future doc updates?

@matthewrmshin matthewrmshin added this to the cylc-8.0a1 milestone Jun 12, 2019
@matthewrmshin matthewrmshin added the doc Documentation label Jun 12, 2019
CHANGES.md Outdated Show resolved Hide resolved
@kinow kinow changed the title Move documenation to new cylc/cylc-doc repo. Move documentation to new cylc/cylc-doc repo. Jun 12, 2019
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some unused imports that can be fixed now or after the merge. The changelog as well, it could use #3180 as placeholder ticket

.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
@hjoliver
Copy link
Member Author

@kinow - review comments addressed.

Copy link
Member

@dwsutherland dwsutherland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hjoliver hjoliver merged commit f67b13b into cylc:master Jun 13, 2019
@hjoliver hjoliver deleted the mv-docs-other-repo branch June 13, 2019 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer docs to cylc/cylc-doc
4 participants