-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More flaky tests #3244
More flaky tests #3244
Conversation
988b3ef
to
ff4826c
Compare
Looks like these are failing on Travis CI:
|
ff4826c
to
7b91204
Compare
It doesn't make any sense that these tests (especially the one about the travis host name being used instead of localhost) didn't fail before. I saw the Travis failure some hours ago, but looks like you just pushed a change. Will review once Travis is done building (and has hopefully passed this time :) ) |
Hmm, failure on Travis. Not related?
|
Definitely flaky... passed on my machine.. |
aa04f5e
to
4fb25fe
Compare
4fb25fe
to
4242da6
Compare
Finally pass with a workaround! |
All of them are to do with host name. For some reason, our logic is now returning the literal string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
These changes partially address #2894
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.